chore: Refactor Arrow Array and Schema allocation in ColumnReader and MetadataColumnReader #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
viirya
commented
Oct 31, 2024
| @@ -52,7 +52,6 @@ const STR_CLASS_NAME: &str = "java/lang/String"; | |||
| /// Parquet read context maintained across multiple JNI calls. | |||
| struct Context { | |||
| pub column_reader: ColumnReader, | |||
| pub arrays: Option<(Arc<FFI_ArrowArray>, Arc<FFI_ArrowSchema>)>, | |||
There was a problem hiding this comment.
This refactoring simplifies the context and the logic. We don't need to keep the array and schema pointers in the producer side.
There was a problem hiding this comment.
It is also easier to reason the array/schema release logic after this refactoring.
kazuyukitanimura
approved these changes
Nov 1, 2024
| cometVector, dictionary, importer.getProvider(), useDecimal128, false, isUuid); | ||
|
|
||
| currentVector = | ||
| new CometDictionaryVector(cometVector, dictionary, importer.getProvider(), useDecimal128); |
There was a problem hiding this comment.
Unrelated but we should not be needing to call CometDictionaryVector twice
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
============================================
+ Coverage 34.28% 34.32% +0.03%
- Complexity 881 887 +6
============================================
Files 112 113 +1
Lines 43478 43588 +110
Branches 9648 9647 -1
============================================
+ Hits 14908 14963 +55
- Misses 25481 25552 +71
+ Partials 3089 3073 -16 ☔ View full report in Codecov by Sentry. |
viirya
force-pushed
the
refactor_array_schema_scan
branch
from
7d7f388
to
583aed6
Compare
|
Thanks @kazuyukitanimura |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1048.
Rationale for this change
What changes are included in this PR?
How are these changes tested?