chore: Add safety check to CometBuffer #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
add_comet_buffer_safety
branch
from
5ccbb7d
to
7c4a8a0
Compare
parthchandra
reviewed
Nov 4, 2024
|
This cannot pass all tests due to an issue (#1059) at Spark side. |
|
I'm considering to add a workaround in Comet as waiting for Spark change might take longer time (and for 3.4/3.5 such change might not easily to backport). |
viirya
force-pushed
the
add_comet_buffer_safety
branch
from
7b0f5ad
to
6141158
Compare
viirya
force-pushed
the
add_comet_buffer_safety
branch
from
6141158
to
e3fdff6
Compare
andygrove
reviewed
Nov 7, 2024
| * Copied from Spark `ColumnarToRowExec`. Comet needs the fix for SPARK-50235 but cannot wait for | ||
| * the fix to be released in Spark versions. We copy the implementation here to apply the fix. | ||
| */ | ||
| case class CometColumnarToRowExec(child: SparkPlan) |
There was a problem hiding this comment.
We could potentially move this to the shim layer and only use when using versions of Spark that do not have the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1035.
Rationale for this change
What changes are included in this PR?
How are these changes tested?