chore: Make list.rs non generic & simplify the code #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andygrove As you mentioned in #1073, it would be interesting to remove all logic related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1114
Start of the discussion: comment in the PR1073
Rationale for this change
Spark supports only i32 indixed arrays but Comet attempts to support both ListArray (i32 indexed) and LargeListArray (i64 indexed). As a result the code in
list.rscontains additional complexity that is not reachable and is not tested anyhow.What changes are included in this PR?
Refactoring of the
list.rs,ListExtract,GetArrayStructFieldandArrayInsertnow accept onlyListArrayinstead ofGenericListArrayHow are these changes tested?
All existing tests.