feat(substrait): remove dependency on datafusion default features #13594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thanks @notfilippo -- this looks like a good change to me.
I wonder if there is some way we can add a CI test for this (to avoid breaking it in the future) -- perhaps something like
datafusion/.github/workflows/rust.yml
Line 81 in ddee471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13593
What changes are included in this PR?
physicalfeature, which enables production and consumption of physical substrait plans.Are these changes tested?
Yes, running
cargo tree -p datafusion-substraitwith and without the--no-default-featuresshows thatparquetand many other dependencies are not included.Are there any user-facing changes?
No, the new feature is enabled by default. Users who might want to benefit from this change will have to use
default-features = falsewhen including thedatafusion-substraitcrate.