Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix judgment for registry configed in DefaultApplicationDeployer #14874

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Nov 7, 2024

What is the purpose of the change?

fix #14859

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@laywin laywin closed this Nov 8, 2024
@laywin laywin reopened this Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.19%. Comparing base (ef6e8bd) to head (02c2f20).
Report is 88 commits behind head on 3.3.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14874        +/-   ##
=============================================
- Coverage   37.53%     2.19%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389686   +1308949     
  Branches    12005    220210    +208205     
=============================================
+ Hits        30304     30570       +266     
- Misses      46042   1354680   +1308638     
- Partials     4391      4436        +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

@chickenlj PTAL

boolean registryConfiged = CollectionUtils.isNotEmpty(
moduleModel.getApplicationModel().getApplicationConfigManager().getRegistries());

if (registryConfiged) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing to hasRegistryInteraction(), the new condition missed to check the registry configuration that is restricted in ServiceConfig. So this change might fix the registration issue for users programmatically using API but probably will cause new issue for users exporting services the other way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing to hasRegistryInteraction(), the new condition missed to check the registry configuration that is restricted in ServiceConfig. So this change might fix the registration issue for users programmatically using API but probably will cause new issue for users exporting services the other way.

i think it should to start the registry schedule if there is a registry config in application config. because service export may happens after dubbo started, so the instance can't be registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants