-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix judgment for registry configed in DefaultApplicationDeployer #14874
base: 3.3
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #14874 +/- ##
=============================================
- Coverage 37.53% 2.19% -35.34%
=============================================
Files 1813 26083 +24270
Lines 80737 1389686 +1308949
Branches 12005 220210 +208205
=============================================
+ Hits 30304 30570 +266
- Misses 46042 1354680 +1308638
- Partials 4391 4436 +45 ☔ View full report in Codecov by Sentry. |
@chickenlj PTAL |
boolean registryConfiged = CollectionUtils.isNotEmpty( | ||
moduleModel.getApplicationModel().getApplicationConfigManager().getRegistries()); | ||
|
||
if (registryConfiged) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing to hasRegistryInteraction()
, the new condition missed to check the registry configuration that is restricted in ServiceConfig. So this change might fix the registration issue for users programmatically using API but probably will cause new issue for users exporting services the other way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing to
hasRegistryInteraction()
, the new condition missed to check the registry configuration that is restricted in ServiceConfig. So this change might fix the registration issue for users programmatically using API but probably will cause new issue for users exporting services the other way.
i think it should to start the registry schedule if there is a registry config in application config. because service export may happens after dubbo started, so the instance can't be registry.
What is the purpose of the change?
fix #14859
Checklist