Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Change base Docker image from Alpine to Debian #2348

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

aleksraiden
Copy link
Contributor

@aleksraiden aleksraiden commented Jun 1, 2024

Change base Docker image from alpine 3.16 (as an too old system) into Debian - use bookworm-slim image. (see our issue too #2344)

As we can't upgrade alpine, for continuous use latest rocksdb release and fix some mysterious (for me, see #2327) bugs with jemalloc in alpine, I propagate an new Docker, based on latest Debian slim.

Basically, nothing to change from original, just change an image and use apt instead of apk. Added only an apt clean command for cleanup system after upgrade.

Result image has an ~ 120Mb size instead of ~40 Mb in alpine.

@aleksraiden aleksraiden changed the title Change base Docker image from Alpine to Debian build: Change base Docker image from Alpine to Debian Jun 1, 2024
@aleksraiden
Copy link
Contributor Author

Thanks to @thbley about the some fix and optimizing from #2344

@aleksraiden aleksraiden marked this pull request as draft June 1, 2024 09:46
@aleksraiden aleksraiden self-assigned this Jun 1, 2024
@aleksraiden aleksraiden marked this pull request as ready for review June 1, 2024 10:37
@git-hulk
Copy link
Member

git-hulk commented Jun 1, 2024

@aleksraiden Thanks for taking care of this.

@aleksraiden
Copy link
Contributor Author

Some troubles in healthcheck on docker, try to fix today or tomorrow

@PragmaTwice
Copy link
Member

PragmaTwice commented Jun 2, 2024

As we can't upgrade alpine

Hmm is there any issue for us about upgrading alpine?

@PragmaTwice
Copy link
Member

And also, do you have any suggestion to select between debian and ubuntu?

Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thbley
Copy link

thbley commented Jun 2, 2024

And also, do you have any suggestion to select between debian and ubuntu?

To me both are quite good and work great in production for many companies.
Ubuntu lts versions have longer support lifetime, more recent versions of packages (e.g. gcc, openssl), Debian more stable, less recent versions. Key for alpine is size and security, but no glibc.

for package version comparison:
https://packages.ubuntu.com/
https://www.debian.org/distrib/packages
https://pkgs.alpinelinux.org/packages

@aleksraiden
Copy link
Contributor Author

Yeah, sorry, I have not any real experience with ubuntu, but over 10 y use Debian on all our servers, so use it as a matured server-side os.

In other hands, the idea of multiple images (like a community or non-official, in separate directory etc) with other base images my Ok and I can support this feature.

In my mind, ideally - alpine 3.20+ but we cant switch due to some dependency. So - Debian looks like good solution at now.

@aleksraiden
Copy link
Contributor Author

As we can't upgrade alpine

Hmm is there any issue for us about upgrading alpine?

With @torwig we have a lot of internal tests and a core point is libexecinfo dependency

@PragmaTwice PragmaTwice merged commit 5744d1b into unstable Jun 3, 2024
64 checks passed
@aleksraiden aleksraiden deleted the aleksraiden-docker-bookworm-slim branch June 3, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants