fix(string): reset the value of expired key for incrby cmd #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Would you like to add some go test cases to cover the changes?
Related cases can be found here: https://github.com/apache/kvrocks/blob/unstable/tests/gocase/unit/type/incr/incr_test.go .
PragmaTwice
changed the title
Ok, no problem. I will add the go test cases ASAP |
…arsing and calculation.
FishYoung
force-pushed
the
fishyoung/fix_expired_key_incr
branch
from
f80db1f to
5ea8d17
Compare
FishYoung
force-pushed
the
fishyoung/fix_expired_key_incr
branch
from
5ea8d17 to
80ffc13
Compare
PragmaTwice
approved these changes
Nov 18, 2024
git-hulk
approved these changes
Nov 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset the value of expired key to prevent the following parsing and calculation.
This closes #2660