HDDS-11640. Deletion services in SCM, OM and DN should have consistent metrics #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Nov 15, 2024
Comment on lines
234
to
240
| public void incrSuccessCountInLastIteration(long successCountInLastIteration) { | ||
| this.successCountInLastIteration.incr(successCountInLastIteration); | ||
| } | ||
|
|
||
| public void incrSuccessBytesInLastIteration(long successBytesInLastIteration) { | ||
| this.successBytesInLastIteration.incr(successBytesInLastIteration); | ||
| } |
There was a problem hiding this comment.
Thanks @Tejaskriya for the patch.
Parameters can be renamed to delta to fix checkstyle failures:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/BlockDeletingServiceMetrics.java
234: 'successCountInLastIteration' hides a field.
238: 'successBytesInLastIteration' hides a field.
https://github.com/Tejaskriya/ozone/actions/runs/11813260671/job/32909976492
| @@ -127,12 +128,14 @@ public Long getNumBlocksToDelete() { | |||
| public BackgroundTaskQueue getTasks() { | |||
| BackgroundTaskQueue queue = new BackgroundTaskQueue(); | |||
|
|
|||
| metrics.resetLastIterationCounts(); | |||
There was a problem hiding this comment.
If someone queries the metrics after the resetLastIterationCounts is done and before we populate all the counters again, won't we get inconsistent result?
There was a problem hiding this comment.
I have changed it now, to store the counter and update the metrics only at the end of each iteration. COuld you please take a look at the update?
|
@errose28 @ashishkumar50 could you please review the PR? |
...ervice/src/main/java/org/apache/hadoop/ozone/container/common/impl/BlockDeletingService.java
Outdated
Show resolved
Hide resolved
...va/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingTask.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, SCM and DN have only total metrics, they don't track the numbers for each iteration of the deleting services. In order to view the progress of deletion using metrics, iteration specific metrics will useful.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11640
How was this patch tested?
Tested Manually