HDDS-11723. Tool to better micro benchmark hbase performance in Ozone #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
reviewed
Nov 22, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Nov 22, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Thanks @duongkame . lgtm
@jojochuang Do you also want to take a quick look?
adoroszlai
reviewed
Nov 22, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Siyao Meng <[email protected]>
adoroszlai
reviewed
Nov 22, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Show resolved
Hide resolved
chungen0126
reviewed
Nov 22, 2024
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java
Show resolved
Hide resolved
|
Thanks for reviewing @smengcl @adoroszlai @chungen0126. |
|
Merged. Thanks @duongkame for the patch. Thanks @adoroszlai @chungen0126 for reviewing this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See https://issues.apache.org/jira/browse/HDDS-11723.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11723
How was this patch tested?
CI.