Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SINGA-236 memory pool #255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SINGA-236 memory pool #255

wants to merge 3 commits into from

Conversation

liyuchenmike
Copy link
Contributor

Update the memory pool.

  1. Simplify the APIs.
  2. No fixed allocation is required.

nudles
nudles reviewed Sep 14, 2016
View reviewed changes
src/core/memory/memory.cc
pAllocUint->pPrev = pCurUint;
}
pAllocUint = pCurUint;
pAllocBlk = new Block((char*)(pCurUint) + sizeof(struct _Uint), size);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size of the allocated block + sizeof (struct _Uint) == size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the requested size is 1024, then we allocated 1024+16, 16 is used for metadata of the mempool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyuchenmike @nudles