Update Behat dependencies to friends-of-behat for sf5 compat #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to break the tests. |
Indeed ! :) @soyuka told me he'll take a look to understand why. |
|
There is work to do to integrate behatch when switching to these libraries. I did it in our app recently but it's quite some work depending on the number of existing Behat Context, anyway it is not as easy as replacing the libs from my experience. |
soyuka
changed the title
|
If anyone wants to give it a try don't hesitate. We should also update the symfony2-extension package. |
|
On a first quick look, the error comes from those hacks https://github.com/api-platform/core/blob/master/features/bootstrap/HttpHeaderContext.php#L35 We can't set null anymore |
thbil
force-pushed
the
fix/sf5-compatibility
branch
3 times, most recently
from
9300d58 to
b076f82
Compare
dunglas
force-pushed
the
fix/sf5-compatibility
branch
from
ee030f5 to
e12f8f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
behat/minkbyfriends-of-behat/mink,behat/mink-browserkit-driverbyfriends-of-behat/mink-browserkit-driver, andbehat/mink-extensionbyfriends-of-behat/mink-extensionfor sf5 compat (see Behat/MinkExtension#360 (comment)).