Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve pnpm support for dashboard build scripts. #232

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

FangSen9000
Copy link

@FangSen9000 FangSen9000 commented Aug 15, 2022

I am working on the APISIX dashboard project to migrate its package manager from yarn to pnpm. His GitHub workflow uses this script to detect RPM packaging. We need some minor changes to make the workflow work normally.
apache/apisix-dashboard#2604

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2022

CLA assistant check
All committers have signed the CLA.

@tzssangglass
Copy link
Contributor

Looks like that this PR isn't finished yet?

@FangSen9000
Copy link
Author

Looks like that this PR isn't finished yet?

Yes, but if the apisix build tool is not changed during the merge, the packaged RPM workflow of the merged PR will have an error. (after all, you are upstream of RPM workflow)

Do you want to copy this script to the local warehouse or request you to change this tool. We need to discuss it for some time. At that time, we will close this PR or request changes to the merge tool.

@FangSen9000 FangSen9000 changed the title feat: Improve pnpm support for dashboard build scripts. feat: Improve pnpm support for dashboard build scripts. (WIP) Aug 15, 2022
@FangSen9000
Copy link
Author

FangSen9000 commented Aug 15, 2022

WIP, however, I can be sure that all the changes to the tool are just these two lines

Update, the task has been completed
at apache/apisix-dashboard#2604 now

Wait for @bzp2010 's opinions

@tzssangglass tzssangglass requested a review from bzp2010 August 15, 2022 16:43
@FangSen9000 FangSen9000 changed the title feat: Improve pnpm support for dashboard build scripts. (WIP) feat: Improve pnpm support for dashboard build scripts. Aug 17, 2022
@tzssangglass
Copy link
Contributor

ping @bzp2010 does this PR is needed?

@FangSen9000 FangSen9000 marked this pull request as draft August 23, 2022 15:24
@FangSen9000 FangSen9000 marked this pull request as ready for review August 25, 2022 01:08
@bzp2010
Copy link
Collaborator

bzp2010 commented Aug 25, 2022

@FangSen9000

I think we need to wait for the PR merge in the APISIX Dashboard project before doing this.

BTW, I don't think using pnpm in the build session will help a lot with build speed, but it will improve our development experience.

@FangSen9000
Copy link
Author

@FangSen9000

I think we need to wait for the PR merge in the APISIX Dashboard project before doing this.

BTW, I don't think using pnpm in the build session will help a lot with build speed, but it will improve our development experience.
ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants