-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Port of Ruby combat framework to Kotlin #376
Open
garyttierney
wants to merge
11
commits into
kotlin-experiments
Choose a base branch
from
kotlin-combat
base: kotlin-experiments
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My current TODO list for this (not counting the numerous |
garyttierney
force-pushed
the
kotlin-experiments
branch
from
January 17, 2018 22:25
5211b9b
to
97896a3
Compare
garyttierney
added
medium
needs-discussion
The project maintainers request input from users
help wanted
The project maintainers request development help from users
labels
Jan 18, 2018
This fixes the recording of projectile updates in a region.
garyttierney
force-pushed
the
kotlin-combat
branch
from
January 28, 2018 18:46
7e2ef0c
to
0e98d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
help wanted
The project maintainers request development help from users
medium
needs-discussion
The project maintainers request input from users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not in scope for the
kotlin-experiments
branch, this is something I'd still like to get some feedback on. All of the basics are there for melee + ranged, including max hit / accuracy. The DSL itself is almost a one-to-one port of what was done in Ruby, with some Kotlin specifics to make the framework more idiomatic.See the Scimitar/Bow plugins for examples of how to configure new weapon classes and weapons.
Scimitar
andBow
areWeaponClass
objects that are defined bymelee_classes.kt
andranged_classes.kt
.