-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Essence Mining #424
base: kotlin-experiments
Are you sure you want to change the base?
Add Essence Mining #424
Conversation
The message sent when player does not have a pickaxe they can use should be sent only after the player has reached the rock.
Renamed to avoid conflict between the const and enum declaration
Ores that do not contain an item id or do not deplete will never pass the current tests
Codecov Report
@@ Coverage Diff @@
## kotlin-experiments #424 +/- ##
========================================================
+ Coverage 23.23% 23.23% +<.01%
Complexity 811 811
========================================================
Files 643 643
Lines 11123 11130 +7
Branches 1632 1637 +5
========================================================
+ Hits 2584 2586 +2
- Misses 8251 8252 +1
- Partials 288 292 +4
Continue to review full report at Codecov.
|
Looks great (sorry for the enormous delay in reviewing this), needs tests for the essence mining though. |
Addresses Issue #184 where support for mining Rune and Pure essence is requested