Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Essence Mining #424

Open
wants to merge 15 commits into
base: kotlin-experiments
Choose a base branch
from
Open

Add Essence Mining #424

wants to merge 15 commits into from

Conversation

Tomm0017
Copy link

Addresses Issue #184 where support for mining Rune and Pure essence is requested

@Tomm0017 Tomm0017 changed the title Essence mining Add Essence Mining Apr 25, 2019
= added 3 commits April 25, 2019 06:29
Renamed to avoid conflict between the const and enum declaration
Ores that do not contain an item id or do not deplete will never pass
the current tests
@codecov-io
Copy link

Codecov Report

Merging #424 into kotlin-experiments will increase coverage by <.01%.
The diff coverage is 30%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             kotlin-experiments     #424      +/-   ##
========================================================
+ Coverage                 23.23%   23.23%   +<.01%     
  Complexity                  811      811              
========================================================
  Files                       643      643              
  Lines                     11123    11130       +7     
  Branches                   1632     1637       +5     
========================================================
+ Hits                       2584     2586       +2     
- Misses                     8251     8252       +1     
- Partials                    288      292       +4
Impacted Files Coverage Δ Complexity Δ
game/plugin/skills/mining/src/MiningAction.kt 27.77% <23.8%> (-2.53%) 0 <0> (ø)
game/plugin/skills/mining/src/MiningTarget.kt 37.5% <42.85%> (+4.16%) 0 <0> (ø) ⬇️
game/plugin/skills/mining/src/ProspectingAction.kt 47.05% <50%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd06a69...a5f436b. Read the comment docs.

@Major-
Copy link
Member

Major- commented Jul 13, 2019

Looks great (sorry for the enormous delay in reviewing this), needs tests for the essence mining though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants