-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: @oneOf input object support #537
base: main
Are you sure you want to change the base?
Conversation
Added support for oneOf from graphql-js and new template renderer
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, but otherwise this looks good!
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/OneOfInputObjectTemplate.swift
Outdated
Show resolved
Hide resolved
Updating the SPMInXcodeProject codegen config to commit the animal kingdom package.swift and use local version of library
This reverts commit bb3cce4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Zach, thank you!
Adding support for @OneOf Input Objects, more info can be found in the official RFC here: graphql/graphql-spec#825
Closes apollographql/apollo-ios#3430