Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo-codegen-typescript): Support scalar JSDoc annotations #2545

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nalchevanidze
Copy link

@nalchevanidze nalchevanidze commented Jan 14, 2022

fixes #2544

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

scalar-annotation-tests
@apollo-cla
Copy link

@nalchevanidze: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@nalchevanidze nalchevanidze changed the title support-scalar-jsdoc-annotations feat: support scalar JSDoc annotations for Typescript Jan 14, 2022
@nalchevanidze nalchevanidze changed the title feat: support scalar JSDoc annotations for Typescript feat: Support scalar JSDoc annotations for Typescript Jan 14, 2022
@nalchevanidze nalchevanidze changed the title feat: Support scalar JSDoc annotations for Typescript feat(apollo-codegen-typescript): Support scalar JSDoc annotations Jan 14, 2022
@nalchevanidze
Copy link
Author

There are some cases and tests that need to be covered, and that will be addressed. But the question is if you like the idea too? We can also implement a more general approach with a plugin interface where I could put this code in the plugin and combine it with the base implementation?

@nalchevanidze nalchevanidze marked this pull request as ready for review August 15, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JSDoc to Generate Types for GQL Scalars
2 participants