Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Adds missing peer dependencies to ssr #3681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arcanis
Copy link

@arcanis arcanis commented Nov 11, 2019

@apollo/react-ssr has an unmet peer dependency on various packages through @apollo/react-common and @apollo/react-hooks. This diff fixes that (which otherwise cause react-ssr to fail strictness checks in modern package managers).

As long as you're here, can you please give a look to the following related PRs? 😃

@arcanis
Copy link
Author

arcanis commented Dec 2, 2019

Ping @hwillson? Without these patches, Yarn users will see a lot of warnings in future releases 🙂

@jonaskuske
Copy link

jonaskuske commented Mar 30, 2020

Ping again (@hwillson ?) 😬

Yarn users (like me) are seeing a lot of warnings now. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants