Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FOUN-575] persisted queries with client names #2239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FOUN-575] persisted queries with client names #2239

wants to merge 2 commits into from
+160 −9

Conversation

glasser
Copy link
Member

@glasser glasser commented Oct 25, 2024

This depends on unreleased functionality of GraphOS.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 25, 2024 •
edited
Loading

✅ Docs Preview Ready

No new or changed pages found.

@glasser
[FOUN-575] persisted queries with client names
66438eb 
This depends on unreleased functionality of GraphOS.
@glasser glasser marked this pull request as ready for review November 14, 2024 22:56
@glasser glasser requested a review from a team as a code owner November 14, 2024 22:56
jonathanrainer
jonathanrainer approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jonathanrainer jonathanrainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

All looks grand to me, would be good to have some extra docs on the new option and how to use it but can't see any problem moving forward from a technical standpoint

@glasser
Copy link
Member Author

glasser commented Nov 20, 2024

I think more in-depth docs will be in the main GraphOS Persisted Queries docs page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanrainer jonathanrainer jonathanrainer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glasser @svc-apollo-docs @jonathanrainer