-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some small things #18
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as correct `None`
…ted` is `True` for higher resolutions especially
tolgacangoz
changed the title
Update diffusion_config and fix issues with vision model download and scaling
Fix all
Oct 11, 2024
tolgacangoz
commented
Oct 11, 2024
tolgacangoz
changed the title
Proposes to fix them all
One PR to fix them all, One PR to find them, One PR to bring them all, and in the darkness bind them
Oct 11, 2024
tolgacangoz
changed the title
One PR to fix them all, One PR to find them, One PR to bring them all, and in the darkness bind them
Oct 11, 2024
One PR to fix them all, One PR to find them, One PR to bring them all, and in the darkness bind them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far, PR is undergoing internal review now
tolgacangoz
commented
Oct 14, 2024
Thanks @tolgacangoz I think your PR fixed most of the issues. Please check the above my proposal (i think it did not fix the typos you mentioned) |
tolgacangoz
commented
Oct 16, 2024
tolgacangoz
changed the title
Fix some small things
Oct 16, 2024
One PR to fix them all, One PR to find them, One PR to bring them all, and in the darkness bind them
This PR now fixes some small nits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes to fix #10
This pull request updates the
cc12m_256x256.yaml
andcc12m_1024x1024.yaml
files by adding adiffusion_config
section because samplers are created withdiffusion_config.sampler_config
:ml-mdm/ml_mdm/diffusion.py
Line 94 in 3695917
ml-mdm/ml_mdm/diffusion.py
Line 287 in 3695917
Also,
diffusion_config.no_use_residual
is needed:ml-mdm/ml_mdm/diffusion.py
Line 262 in 3695917
None
in the file is read by'None'
-as a string.Proposes to fix #6
Fixes old module mimicry.
This pull request proposes a refactoring of the
samplers.py
file to ensure correct handling of scaling when theconfig.schedule_shifted
flag is set toTrue
. This change improves the behavior of the code, especially for higher resolutions.Prompt =
a blue jay stops on the top of a helmet of Japanese samurai, background with sakura tree
Guidance scale =
7.5
Thresholding =
clip
Number of steps =
250
@MultiPath @Shuangfei @luke-carlson