PR review

.github/workflows/reusable_pull_request.yml

@@ -15,13 +15,13 @@ on:
         type: boolean
         description: "Boolean to enable the docs check job. Defaults to true."
         default: true
-      acceptable_language_check_enabled:
+      unacceptable_language_check_enabled:
         type: boolean
         description: "Boolean to enable the acceptable language check job. Defaults to true."
         default: true
-      acceptable_language_check_word_list:
+      unacceptable_language_check_word_list:
         type: string
-        description: "List of unacceptable words. Defaults to a sensitive list of words."
+        description: "List of unacceptable words. Defaults to a sensible list of words."
         default: "blacklist whitelist slave master sane sanity insane insanity kill killed killing hang hung hanged hanging" #ignore-unacceptable-language
 
 ## We are cancelling previously triggered workflow runs
@@ -93,15 +93,15 @@ jobs:
           swift package plugin generate-documentation --target "$target" --warnings-as-errors --analyze --level detailed
         done
 
-  acceptable-language-check:
-    name: Acceptable language check
-    if: ${{ inputs.acceptable_language_check_enabled }}
+  unacceptable-language-check:
+    name: Unacceptable language check
+    if: ${{ inputs.unacceptable_language_check_enabled }}
     runs-on: ubuntu-latest
     timeout-minutes: 1
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
-    - name: Run acceptable language check
+    - name: Run unacceptable language check
       env:
         UNACCEPTABLE_LANGUAGE_PATTERNS: ${{ inputs.acceptable_language_check_word_list}}
-      run: ./scripts/acceptable_language_check.sh
+      run: ./scripts/unacceptable_language_check.sh

IntegrationTests/tests_01_http/defines.sh

@@ -141,9 +141,10 @@ function stop_server() {
         do_netstat "$token_type"
         assert_number_of_open_fds_for_pid_equals "$token_pid" "$token_open_fds"
     fi
-    kill -0 "$token_pid" # assert server is still running ignore-unacceptable-language
-    ###kill -INT "$token_pid" # tell server to shut down gracefully ignore-unacceptable-language
-    kill "$token_pid" # tell server to shut down gracefully ignore-unacceptable-language
+    # assert server is still running
+    kill -0 "$token_pid" # ignore-unacceptable-language
+    # tell server to shut down gracefully
+    kill "$token_pid" # ignore-unacceptable-language
     for f in $(seq 20); do
         if ! kill -0 "$token_pid" 2> /dev/null; then # ignore-unacceptable-language
             break # good, dead

NOTICE.txt

@@ -35,16 +35,6 @@ This product is heavily influenced by Netty.
 
 ---
 
-This product contains a derivation of the Tony Stone's 'process_test_files.rb'.
-
-  * LICENSE (Apache License 2.0):
-    * https://www.apache.org/licenses/LICENSE-2.0
-  * HOMEPAGE:
-    * https://github.com/tonystone/build-tools/commit/6c417b7569df24597a48a9aa7b505b636e8f73a1
-    * https://github.com/tonystone/build-tools/blob/cf3440f43bde2053430285b4ed0709c865892eb5/source/xctest_tool.rb
-
----
-
 This product contains NodeJS's llhttp.
 
   * LICENSE (MIT):