[GHA] Cxx interoperability compatibility check #2788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation Another reusable check is to make sure that all library products of a package are successfully building when consumed from a module that has Cxx interoperability enabled. # Modification This PR adds a new check to the reusable workflow to check for Cxx interoperability compatibility. # Result This should be one of the last reusable workflow checks.
FranzBusch
force-pushed
the
fb-gha-cxx-interop
branch
from
b224b7e to
2c73c3f
Compare
|
The new Cxx is expected to fail since the script isn't in the repo yet. |
glbrntt
reviewed
Jul 12, 2024
| @@ -191,3 +195,18 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| - name: Run format check | |||
| run: swift format lint --parallel --recursive --strict | |||
|
|
|||
| cxx-interoperability-check: | |||
There was a problem hiding this comment.
minor usability: should we call this cxx-interop-check?
| if: ${{ inputs.cxx_interoperability_check_enabled }} | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: swift:5.10-noble |
There was a problem hiding this comment.
We currently run this on 5.9 and 5.10, what coverage do we want moving forward?
There was a problem hiding this comment.
I just realised that as well. I am currently extracting the matrix based build into a separate workflow so we can easily add more matrix based jobs to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another reusable check is to make sure that all library products of a package are successfully building when consumed from a module that has Cxx interoperability enabled.
Modification
This PR adds a new check to the reusable workflow to check for Cxx interoperability compatibility.
Result
This should be one of the last reusable workflow checks.