Enable MemberImportVisibility check on all targets #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
06f91b6 to
1569b89
Compare
rnro
changed the title
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
1569b89 to
fff7794
Compare
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
fff7794 to
7f258b8
Compare
FranzBusch
approved these changes
Dec 13, 2024
FranzBusch
approved these changes
Dec 13, 2024
|
This broke the build with the 6.1 and 6.2 snapshot toolchains both on this linux CI and my Android CI today, spitting out thousands of lines of errors. |
|
Sorry about that @finagolfin - I've put up a PR to revert the change for now. I missed the missing imports on this repo. |
|
No problem, the whole point of these trunk CI is to catch these issues early. Btw, now that 6.1 has been branched, I notice it is not tested on these NIO CI. |
rnro
added a commit
that referenced
this pull request
Dec 16, 2024
rnro
added a commit
that referenced
this pull request
Dec 17, 2024
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts. See #3021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.