Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fetchAll" function match for php 8 function "fetchAll" #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

"fetchAll" function match for php 8 function "fetchAll" #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Flavours/Snowflake/PDO/Statement74.php
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not compatible with PHP 74

Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function fetch($how = null, $orientation = null, $offset = null)
return call_user_func_array([$this, __FUNCTION__], func_get_args());
}

public function fetchAll($how = PDO::FETCH_BOTH, $class_name = null, $ctor_args = null)
public function fetchAll($how = PDO::FETCH_BOTH, $class_name = null,mixed ...$ctor_args):array
{
if ($this->exec) {
return call_user_func_array([$this->exec, __FUNCTION__], func_get_args());
Expand Down
2 changes: 1 addition & 1 deletion src/Flavours/Snowflake/PDO/Statement80.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function fetch($how = null, $orientation = null, $offset = null): mixed
return call_user_func_array([$this, __FUNCTION__], func_get_args());
}

public function fetchAll(int $mode = PDO::FETCH_DEFAULT, mixed ...$args): array
public function fetchAll($how = PDO::FETCH_BOTH, $class_name = null,mixed ...$ctor_args):array
{
if ($this->exec) {
return call_user_func_array([$this->exec, __FUNCTION__], func_get_args());
Expand Down