Update server-build.yml #37702
Update server-build.yml #37702
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/server-build.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/server-build.yml
349-349: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 yamllint (1.35.1)
.github/workflows/server-build.yml
[error] 348-348: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/server-build.yml (1)
347-348:
Verify the removal of tar extraction step
The commented tar extraction step might break the cache restoration process. Please ensure that the server.jar artifact is properly handled without this step.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 348-348: trailing spaces
(trailing-spaces)
| tar -xzvf ./server.jar | ||
| # tar -xzvf ./server.jar | ||
|
|
||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Update actions/checkout to v4
The checkout action version v2 is outdated. Other steps in this workflow are using v4, which includes important security updates and performance improvements.
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v4📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v4 |
🧰 Tools
🪛 actionlint (1.7.4)
349-349: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
| - name: Setup upterm session | ||
| uses: lhotari/action-upterm@v1 |
There was a problem hiding this comment.
Restrict upterm session access
Adding unrestricted upterm session access to the workflow runner poses a security risk. Consider:
- Adding conditions to limit when the session is created (e.g., only on workflow failure)
- Restricting access to specific users or teams
- name: Setup upterm session
+ if: failure()
uses: lhotari/action-upterm@v1
+ with:
+ limit-access-to: appsmithorg/server-team📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Setup upterm session | |
| uses: lhotari/action-upterm@v1 | |
| - name: Setup upterm session | |
| if: failure() | |
| uses: lhotari/action-upterm@v1 | |
| with: | |
| limit-access-to: appsmithorg/server-team |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Warning
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12026463021
Commit: c1bfa6b
Cypress dashboard.
Tags: @tag.All
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Tue, 26 Nov 2024 10:23:49 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit