fix #518: added switch to allow manual ABI specification #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heueristik
added
P1 🔜
heueristik
commented
Jan 6, 2022
| @@ -12,6 +12,7 @@ import { | |||
| SPACING, | |||
| Info, | |||
| } from '@aragon/ui'; | |||
| import Switch from '@material-ui/core/Switch'; | |||
There was a problem hiding this comment.
I didn't know how to use components/Switchs/BlueSwitch.tsx and didn't find an example.
|
For example, the manual ABI specification is necessary to interact with the implementation behind a Gnosis Safe Proxy (see https://gnosis-safe.io/app/rin:0xA7B66EbD4CAE2A7D18cDe96fCA3e362FfCE09601/transactions/0x99c9f2c0a1d87842ab17df93325756ba531a51ff73da7fc21cafc0735a27e536). |
|
We need this to be merged because the AN DAO should be able to remove signers from a Gnosis Safe multi-sig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I added the possibility to manually specify the ABI to allow interaction with proxied functions (see #518).
DAOs are currently not visible on Rinkeby (see #519), I couldn't test it with an actual transaction.
Because this is the first time I am working with react, it needs a proper review. Maybe things can be done more elegantly.