Add NFT metadata #38
Merged
Add NFT metadata #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaniza
reviewed
Dec 11, 2024
| @@ -38,7 +49,7 @@ contract Lock is ILock, ERC721Enumerable, UUPSUpgradeable, DaoAuthorizable, Reen | |||
|
|
|||
| function supportsInterface( | |||
| bytes4 _interfaceId | |||
| ) public view override(ERC721Enumerable) returns (bool) { | |||
| ) public view override(ERC721Enumerable, ERC721URIStorageUpgradeable) returns (bool) { | |||
There was a problem hiding this comment.
Strictly speaking, we should test that the supports interface check is correctly returning as expected for Enumerable vs URI Storage. Of the 2 I think Enumerable is more important to be able to introspect so would want to make sure that is not lost through the override
There was a problem hiding this comment.
True. I added 2 asserts on test/escrow/escrow/Lock.t.sol to verify both interfaces are supported. I also checked and all the parent functions use || super.supportsInterface(..) so they should propagate correctly through the inheritance chain.
jordaniza
reviewed
Dec 13, 2024
src/escrow/increasing/Lock.sol
Outdated
| ERC721URIStorageUpgradeable, | ||
| UUPSUpgradeable, | ||
| DaoAuthorizable, | ||
| ReentrancyGuard |
There was a problem hiding this comment.
inheritance order matters - keep the same order to not mess with storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.