-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove libraries from compile-examples.yml
workflow
#30
base: main
Are you sure you want to change the base?
Conversation
Although the dependancies are listed in the
@per1234 Can you share your thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arduino/compile-sketches action does not automatically install the libraries listed in the depends
field of library.properties
. So you must explicitly specify the library dependencies that should be installed in the GitHub Actions workflow, as was done previously.
There is no such capability by default because the action does not install the Arduino_UnifiedStorage library via Library Manager. Instead, it is being manually installed from the checked out repository.
The addition of such a capability, where the action parses the library.properties
file and then automatically installs the libraries found there, has been proposed but the feature was not implemented so far.
@aliphys Any update on this? |
@sebromero This fix is dependant upon arduino/compile-sketches#205 being merged. |
This PR removes the explicit mention of the libraries in the workflow file.
Arduino_UnifiedStorage/.github/workflows/compile-examples.yml
Lines 69 to 71 in 7739373
Following #29 and this PR all three dependancies are listed inside the library.properties file.