Copy symlinks when calling the CopyDirTo func
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 71.95% 72.17% +0.22%
==========================================
Files 6 6
Lines 353 363 +10
==========================================
+ Hits 254 262 +8
Misses 67 67
- Partials 32 34 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
add-initial-support-to-symlinks
branch
from
bb96577 to
c3afb8e
Compare
alessio-perugini
added
topic: code
alessio-perugini
commented
Sep 7, 2023
paths_test.go
Outdated
Comment on lines
275
to
278
| exist, err = tmp.Join("broken_dest", "broken_symlink").ExistCheck() | ||
| require.False(t, exist) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "too many levels of symbolic links") |
There was a problem hiding this comment.
I have to figure out how to trigger this error on Windows.
EDIT: I'm not able to find a way to reproduce the same message on windows. Skipping this strict check for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support on copying symlink files when calling the
CopyDirTo.We do not travers the link so we might copy also broken symlinks