-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not stop ReadDirRecursive*
on broken symlinks
#30
Conversation
Instead return the symlink as a file in the file list
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 67.83% 69.00% +1.16%
==========================================
Files 7 7
Lines 401 400 -1
==========================================
+ Hits 272 276 +4
+ Misses 94 92 -2
+ Partials 35 32 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for us of the future: if we spot some regression, it could be related to the calling of path.IsDir() instead of path.IsDirCheck().
702b184
to
075c5c8
Compare
Previously if a broken symlink was found the
ReadDirRecursive
stopped with an error.Now the broken symlink is returned as a file.
ReadDirRecursive()
ontestdata/loops/regular_3/
now returns:(cc @matthijskooijman This is part of your PR #13 was trying to do)