Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PathList.Equals method #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added PathList.Equals method #32

wants to merge 1 commit into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 13, 2024

It can be used to compare two PathList.

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 13, 2024
@cmaglie cmaglie self-assigned this Jun 13, 2024
alessio-perugini
alessio-perugini approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good.
The failing tests on windows seems to be related to a recent upgrade of the GH runner, which seems to have disabled te 8.3 short path for mounted disks (D:) in our case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@umbynos umbynos Awaiting requested review from umbynos

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @alessio-perugini