-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended rules (up to 8 rules-sets) #19438
Conversation
|
Nice solution. Let Alex do some tests especially on 1M devices ;-) |
@AleXSR700 We are waiting for your feedback :-) |
Sorry everyone. I thought it had been tested internally already, so I did not run a "proper" test protocol. I will do so once I get back from my vacation. :) |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale, just under review |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR was automatically closed because of being stale. |
No more bump? |
The branch is still available if you want to test and report, we could reopen |
Thank you barbudor for your quick answer. |
Description:
Related issue (if applicable): fixes #15832
This PR add the capability to extended rules up to 8 rules set.
NOTE : Because some constants have to be updated before
user_config_override.h
is included, this feature cannot be simply enabled fromuser_config_override.h
. It requires a dedicated environment inplatformio_tasmota_cenv.ini
Exemple with ESP8266, 4MB flash with 2MB filesystem (USE_UFILESYS is implicit when using an ESP8266 board > 1M):
Exemple with ESP32, 4MB flash with 320KB filesystem (USE_UFILESYS is implicit when using ESP32):
Flash usage: +460 bytes, not counting the mandatory filesystem
Ram usage: + 2648 bytes
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass