Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#22535 applying masking window to any power change #22539

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Nov 23, 2024

Description:

Related issue (if applicable): fixes #22535

Apply a masking window to the MagicSwitch input in case of a power state change whatever is the source.
Should avoid load switch to create disturbances that is falsy understood as a MagicSwitch pulse

tested by OP #crhass

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • [-] The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@barbudor barbudor marked this pull request as ready for review November 23, 2024 12:12
@arendst arendst merged commit 155dea9 into arendst:development Nov 25, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonoff Basic R4 Magicswitch bounces when toggled by command
2 participants