Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support to update record fields #5685

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Nov 12, 2024

Description

This PR adds backend support to update record fields.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (62a1fd0) to head (fd0d061).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5685      +/-   ##
===========================================
+ Coverage    91.98%   92.24%   +0.25%     
===========================================
  Files          161      161              
  Lines         6778     6676     -102     
===========================================
- Hits          6235     6158      -77     
+ Misses         543      518      -25     
Flag Coverage Δ
argilla-server 92.24% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon marked this pull request as ready for review November 12, 2024 12:04
@frascuchon frascuchon added this to the v2.5.0 milestone Nov 14, 2024
@jfcalvo jfcalvo modified the milestones: v2.5.0, v2.6.0 Nov 20, 2024
@@ -24,7 +24,7 @@ jobs:
build:
services:
argilla-server:
image: argilladev/argilla-hf-spaces:develop
image: argilladev/argilla-hf-spaces:pr-5685
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Change before merge

Suggested change
image: argilladev/argilla-hf-spaces:pr-5685
image: argilladev/argilla-hf-spaces:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants