-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keycloak SSO #5711
base: refactor/argilla-server/better-oauth2-integration
Are you sure you want to change the base?
Add keycloak SSO #5711
Conversation
… feature/better-oauth2-integration-keycloak
Related #5691 |
argilla-server/src/argilla_server/security/authentication/oauth2/_backends.py
Outdated
Show resolved
Hide resolved
… feature/better-oauth2-integration-keycloak
|
||
name = "keycloak" | ||
|
||
def oidc_endpoint(self) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we only need this one. The rest of the required values (auth URL or access token URL) should be returned by the oicd_config endpoint based on the oidc endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this works, I updated the docs accordingly. Now configuring keycloak would work by just setting the SOCIAL_AUTH_OIDC_ENDPOINT
environment variable in addition to the oauth yaml.
Add keycloak SSO
Based on discussion in #5691
Points that need some feedback:
Type of change
How Has This Been Tested
Local build & Keycloak installation as described in the documentation.
Checklist