Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next tracking branch #526

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Next tracking branch #526

wants to merge 47 commits into from
+400,644 −189,815

Conversation

arlyon
Copy link
Owner

@arlyon arlyon commented Apr 4, 2024 •
edited
Loading

Monomorphisation is dead. Long live ______

Tracking PR for async-stripe next which addresses longstanding codegen issues from time immemorial and fixes our compile time issues.

Outstanding:

  • miniserde
  • splitting out clients
  • testing
  • polish

It is intended that this branch become the basis for a release candidate for 1.0

mzeitlin11 and others added 7 commits March 19, 2024 21:12
@mzeitlin11
Squashed commit of the following:
9dbe435 
commit 88d7dbc
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Jan 7 15:00:26 2024 -0500

    Use OpenAPI definitions in webhook event definition

commit 6adf3f9
Author: Matthew Zeitlin <[email protected]>
Date:   Fri Jan 5 15:01:03 2024 -0800

    Remove unnecessary test closure

commit c3e3c8f
Author: Matthew Zeitlin <[email protected]>
Date:   Fri Jan 5 12:59:07 2024 -0800

    Remove AsRef<str> generated impl for enums

commit 8157122
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Dec 28 12:45:11 2023 -0500

    Fix polymorphic returned types, add test

commit 4b4f493
Author: Matthew Zeitlin <[email protected]>
Date:   Wed Dec 27 15:57:14 2023 -0500

    Deduplication WIP

commit acc796e
Author: Matthew Zeitlin <[email protected]>
Date:   Tue Dec 26 14:24:59 2023 -0500

    Clean update some codegen, start adding back dedup

commit e09c203
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Dec 23 15:33:37 2023 -0500

    DOC: fix cases of crazy-long lines in doc comments

commit 3009c49
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Dec 23 13:59:38 2023 -0500

    Try to flatten the namespace as much as possible

commit feb13c4
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Dec 23 11:47:48 2023 -0500

    Add test for charge having nullable refunds

commit d8a2dec
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Dec 23 11:33:51 2023 -0500

    List<T> -> Option<List<T>>, no more List<T> defaults

commit 3abe2e6
Author: Matthew Zeitlin <[email protected]>
Date:   Fri Dec 22 13:00:18 2023 -0500

    Patch URLFinder handling

commit 00c139c
Author: Matthew Zeitlin <[email protected]>
Date:   Fri Dec 22 12:04:16 2023 -0500

    Reintegrate search pagination too, add lots more pagination testing

commit ccb9570
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 17 16:31:39 2023 -0500

    Add back AsCursor trait and clean up Expandable removed id method

commit 9930853
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 17 16:00:16 2023 -0500

    Workaround stripe docs change, don't require doc urls

commit b279dcb
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 17 15:53:17 2023 -0500

    Keep  simple, relegate more generated code to specific generated crates

commit 0a4ae20
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 10 14:28:28 2023 -0500

    Add initial README changes, migration guide

commit 8e2f641
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 10 10:50:47 2023 -0500

    Update contributing docs and add codegen readme

commit f7a0999
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 3 20:00:16 2023 -0500

    [skip ci] Add readme to examples directory

commit 11d80e6
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 3 19:41:57 2023 -0500

    Clean up some codegen, add ability to autogenerate generated crate description

commit a6bba63
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Dec 3 13:10:20 2023 -0500

    Make webhook examples more easily runnable without features

commit cfb4fd0
Author: Matthew Zeitlin <[email protected]>
Date:   Fri Dec 1 12:59:10 2023 -0500

    Address initial comments and fix openapi clippy

commit 975440d
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Nov 30 15:16:06 2023 -0500

    Add some manual renaming to lessen breaking changes / use clearer names

commit 8c04938
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Nov 30 14:52:16 2023 -0500

    Remove rustfmt hack for stripe_treasury long lines

commit 30eb3c1
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Nov 30 14:48:16 2023 -0500

    Try using just path to infer object struct name

commit b7630f9
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Nov 30 12:35:03 2023 -0500

    Make sure nested paths are also reexported so don't need stripe_types

commit c402ad9
Author: Matthew Zeitlin <[email protected]>
Date:   Thu Nov 30 12:04:22 2023 -0500

    Allow codegen to replace Default::default() -> None for common option case

commit 12db0bc
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 17:57:26 2023 -0500

    Add examples back to CI

commit 30673e9
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 15:23:29 2023 -0500

    Quiet some tracing, make sure nightly formatting present for CI

commit 3c817c8
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 15:17:15 2023 -0500

    Ci fixups: async-std tests + don't expect out dir to exist

commit 9836631
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 15:08:50 2023 -0500

    Keep examples separate in ci for now

commit 18c4348
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 15:02:39 2023 -0500

    Make CI use same indexmap versions

commit 168eeda
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 14:59:14 2023 -0500

    Try to fix gh actions

commit 1f83a15
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 14:24:26 2023 -0500

    Add more tests for closable issues

commit 0b46685
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 12:40:40 2023 -0500

    Make id inference safer and more correct

commit 0b958dc
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 11:02:44 2023 -0500

    Add some testing

commit 1026ea5
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 10:56:16 2023 -0500

    Move id handling to external mappings file

commit 99d3fa5
Author: Matthew Zeitlin <[email protected]>
Date:   Sun Nov 26 00:20:43 2023 -0500

    Remove no longer used generated code

commit aa9e78c
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 20:34:03 2023 -0500

    Migrate git workflows

commit 6e1b11e
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 20:30:07 2023 -0500

    Migrate old examples, add back from branch

commit 02ba0fa
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 17:53:52 2023 -0500

    Migrate old tests, add back from branch

commit 6ff0bac
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 16:58:03 2023 -0500

    Add generated files and webhook crate

commit 50afbe3
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 16:47:14 2023 -0500

    Add codegen changes

commit edea437
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 13:53:40 2023 -0500

    Remove extra files

commit 25077cb
Author: Matthew Zeitlin <[email protected]>
Date:   Sat Nov 25 13:49:41 2023 -0500

    Stripe client changes + core types crate

More merge changes
@mzeitlin11
Make workflows run on next
854d34f
@mzeitlin11
try bumping msrv
32b0b1d
@mzeitlin11
try bumping msrv
1b02be8
@mzeitlin11
more post merge changes
e7b7da3
@mzeitlin11
Remove default derive for id
00aa897
@arlyon
Merge pull request #452 from mzeitlin11/codegen_revamp
d295678 
Codegen revamp
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.83881% with 3879 lines in your changes are missing coverage. Please review.

Project coverage is 25.62%. Comparing base (c165e2c) to head (020065b).
Report is 167 commits behind head on master.

❗ Current head 020065b differs from pull request most recent head ba6f20d. Consider uploading reports for the commit ba6f20d to get more accurate results

Files Patch % Lines
...d/stripe_billing/src/subscription_item/requests.rs 0.00% 454 Missing ⚠️
.../src/checkout_acss_debit_payment_method_options.rs 0.00% 193 Missing ⚠️
...heckout/src/checkout_acss_debit_mandate_options.rs 0.00% 192 Missing ⚠️
...stripe_billing/src/billing_portal_session/types.rs 31.57% 156 Missing ⚠️
...er_balance_bank_transfer_payment_method_options.rs 0.00% 156 Missing ⚠️
...heckout_customer_balance_payment_method_options.rs 0.00% 138 Missing ⚠️
generated/stripe_billing/src/plan/requests.rs 8.33% 121 Missing ⚠️
generated/stripe_billing/src/portal_flows_flow.rs 0.00% 106 Missing ⚠️
...eckout/src/checkout_card_payment_method_options.rs 0.00% 106 Missing ⚠️
..._billing/src/portal_flows_flow_after_completion.rs 0.00% 95 Missing ⚠️
... and 45 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #526       +/-   ##
===========================================
+ Coverage    5.83%   25.62%   +19.78%     
===========================================
  Files         146      934      +788     
  Lines       22571    99872    +77301     
===========================================
+ Hits         1317    25592    +24275     
- Misses      21254    74280    +53026

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mzeitlin11 and others added 22 commits April 5, 2024 13:37
@mzeitlin11
Remove some client allocations
5f1e0fc
@mzeitlin11
Simplify webhook signature parse
816b9f8
@mzeitlin11
Fix openapi clippy
cff37d3
@arlyon
Merge pull request #528 from mzeitlin11/client_cleanups
562c493 
Simplify client, remove some allocations
@mzeitlin11
Remove prefix validation from ids
3adceac
@mzeitlin11
Merge pull request #530 from mzeitlin11/remove_id_prefixes
7686a0b 
Remove prefix validation from ids
@mzeitlin11
Implement miniserde-based deserialization
f568feb 
Add fixture testing and serialize object keys

Fix object keys in tests

Add object field for serialization without adding field

Split serde gate into serialize and deserialize
@mzeitlin11
Merge pull request #523 from mzeitlin11/miniserde_exp
020065b 
Implement miniserde-based deserialization
@mzeitlin11
Implement Expandable::into_id
fe4d659
@mzeitlin11
FromStr improvements
001d7dd
@mzeitlin11
Merge pull request #536 from mzeitlin11/expandable_into_id
4f29e69 
Implement Expandable::into_id
@mzeitlin11
Merge pull request #537 from mzeitlin11/from_str_tweaks
ba6f20d 
Enum generated FromStr improvements
@mzeitlin11
Client split (#525)
aa89448 
* Rebase

Update codegen code

wip

wip

* Fix doc build

* stripe_* to async-stripe-* crate naming

* Reexport async-stripe-std from root

* Add updated workflow
@arlyon
fix: add some sanity checks to secret keys
0d171ba
@arlyon
Merge pull request #576 from arlyon/arlyon/sk-sanity-checks
2b918fe 
Add basic secret key sanity checks
@augustoccesar
fix(client-core): add tracing dependency
519da4d 
A call to tracing:: was added on #576
but the dependency seems to be missing, which causes the branch to not
compile at the moment.
@augustoccesar
chore(openapi): bump tracing 0.1.36 -> 0.1.40
c81b7e3
@arlyon
Merge pull request #581 from augustoccesar/client-core/add-tracing
54553bf 
fix(client-core): add tracing dependency
@augustoccesar
fix: doc_lazy_continuation linting issue
5f24efb
@augustoccesar
fix: indentation for long lines that are list items
6791e55
@augustoccesar
fix(webhook): linting issues with incomplete Cargo.toml
fae2763 
Rust 1.80 enables check cfg by default. This means that it will look
for unexpected cfg configs.
Currently we are using multiple cfgs that are not defined on
the webhook Cargo.toml. This should fix it.
@augustoccesar
chore: run openapi for current version
e4db632
@augustoccesar augustoccesar mentioned this pull request Aug 15, 2024
Closed
mzeitlin11 and others added 16 commits September 1, 2024 18:44
@mzeitlin11
Avoid ?
d7759d6
@mzeitlin11
Pin stripe mock
fba30c3
@arlyon
Merge pull request #602 from mzeitlin11/comp-time
d14a43b 
Be careful with ? in generated code
@lasantosr
fix enum serialization
0124c6c
@lasantosr
add test
090006f
@mzeitlin11
Merge pull request #605 from lasantosr/fix-enums
0306091 
fix(next): enum serialization
@lasantosr
feat: owned types on requests
6c7486a
@arlyon
Merge pull request #597 from lasantosr/owned-requests
df8a348 
feat(next): owned types on requests
@lasantosr
feat: parse a webhook event without the secret
8b5a6ee
@arlyon
Merge pull request #611 from lasantosr/feature/webhook-insecure
aca76f2 
feat(next): parse a webhook event without the secret
@lasantosr
feat: allows to serialize and deserialize webhook events
595d28c
@lasantosr
expose webhook event data
cf8f958
@mzeitlin11
Merge pull request #625 from lasantosr/feature/expose-webhook-event-data
e246db4 
feat(next): expose webhook event data
@mzeitlin11
Merge pull request #620 from lasantosr/webhook-event-serde
1af8bc9 
feat(next): Serialize and deserialize webhook events
@lasantosr
feat: keep original string on unknown variants
feb39af
@mzeitlin11
Merge pull request #612 from lasantosr/feature/keep-unknown-variants
40caf23 
feat(next): keep original string on unknown variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arlyon @mzeitlin11 @augustoccesar @lasantosr