Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move support of nanopc t6 & lts from edge to current #7476

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

SuperKali
Copy link
Member

Description

Move the support to the current kernel, tested and working fine.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Tested by compiling an unofficial version and tried directly by writing the system to an sd card

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Nov 14, 2024
@SuperKali SuperKali merged commit 378c64a into armbian:main Nov 14, 2024
10 checks passed
@@ -29,7 +28,7 @@ function post_family_tweaks__nanopct6_naming_audios() {
}

# Mainline u-boot
function post_family_config_branch_edge__nanopct6_use_mainline_uboot() {
function post_family_config_branch_current__nanopct6_use_mainline_uboot() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read this correctly, you're removing mainline u-boot from edge branch and adding it to current.
I believe that's not what you want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

That’s what I want, edge is not supported at the moment, patches are not even available, so the board would not work properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just can't disagree more and have reverted this in my tree.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you explain the reasons, maybe I can understand why you disagree with this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your statement is beyond nonsensical: at the present moment, both current and edge are on 6.12. So if one works, why wouldn't the other? Please revert this ASAP.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok...

rpardini added a commit to armsurvivors/armbian-build that referenced this pull request Nov 15, 2024
SuperKali added a commit that referenced this pull request Nov 15, 2024
rpardini pushed a commit that referenced this pull request Nov 17, 2024
rpardini pushed a commit that referenced this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants