Set the encoding to 'utf-8' globally #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I'm still working on it, I want to test it from end to end but for that I need to pack .py files into .exe with pyinstaller. |
|
Hey thanks for looking into this! I have had to make some changes recently to these file encodings to allow for Chinese characters to work (ef08b83) so this might also help with Ukrainian characters. But I'll make sure to test this. As for the exe, there are some files already set as UTF-8 in the current release so it hopefully shouldn't be an issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging throws errors when used with Ukrainian language on Windows machine, by default Windows uses cp1252 I'm forcing it to use utf-8.
See this: https://discord.com/channels/1114128157554004011/1306790318087340082