remove conditional_jit from plot_forest label_idx #2319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2313. This should fix the bug mentioned in that issue.
With the recent improvements to numba it has become more performant yet more restrictive
to support the performance improvements.
plot_forest had a function that was already using forceobj=True, and now due to the
combination of lists, dicts and .append, numba rejects compiling it (probably wasn't doing much
to begin with in previous versions). So I have removed the conditional_jit part.
Checklist
section of the changelog?
📚 Documentation preview 📚: https://arviz--2319.org.readthedocs.build/en/2319/