Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #170: Add vscode theme #537

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Closes #170: Add vscode theme #537

wants to merge 64 commits into from

Conversation

asabaylus
Copy link
Owner

@asabaylus asabaylus commented Oct 7, 2020

yarn && yarn start

see: http://localhost:6006/?path=/story/command-palette--vscode-theme

TODO:

  • Make it work like vscode
  • Write docs
  • Add example child menus
  • Given the user types a shortcut command when the user closes the model and the user reopens the model then it should display the previously typed shortcut command as the default searchbox placeholder
  • Given the user types any character that is not a shortcut command when the user closes the model and the user reopens the model then it should display the default searchbox placeholder

@asabaylus asabaylus changed the title Add vscode theme Closes #170: Add vscode theme Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #537 (686cd5f) into main (71a4984) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          213       213           
  Branches        30        30           
=========================================
  Hits           213       213           
Impacted Files Coverage Δ
src/command-palette.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a4984...686cd5f. Read the comment docs.

@asabaylus asabaylus self-assigned this Oct 7, 2020
@asabaylus asabaylus changed the base branch from release to main December 5, 2020 07:12
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 4 alerts when merging 8b97484 into 41c56ac - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 4 alerts when merging 69f7b3b into 41c56ac - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 4 alerts when merging e94d423 into 41c56ac - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2021

This pull request introduces 1 alert when merging 433d851 into d46f40b - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request introduces 1 alert when merging f3caa8e into 0aee6a2 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request introduces 1 alert when merging 7dc34ac into 6c51218 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request introduces 1 alert when merging 44d80cb into 6c51218 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2021

This pull request introduces 1 alert when merging 347e802 into 6c51218 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 18, 2021

This pull request introduces 1 alert when merging 17de4e8 into 71a4984 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 18, 2021

This pull request introduces 1 alert when merging 686cd5f into 71a4984 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2021

This pull request introduces 2 alerts when merging 7163154 into 4498ef7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Useless assignment to property

@codeclimate
Copy link

codeclimate bot commented May 13, 2021

Code Climate has analyzed commit 1177bf3 and detected 0 issues on this pull request.

View more on Code Climate.

@lgtm-com
Copy link

lgtm-com bot commented May 13, 2021

This pull request introduces 1 alert when merging 1177bf3 into ffb58e2 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@unional
Copy link

unional commented Oct 4, 2022

Hi, will this be available soon? It is mentioned in the README but not in the package. 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants