Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for better rendering of mermaid diagrams #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add changes for better rendering of mermaid diagrams #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/reveal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ class Reveal {
}

nextSlide() {
return this.page.evaluate(_ => Reveal.next());
this.page.evaluate(_ => Reveal.next());
return this.page.evaluate(_ => Reveal.layout());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be:

Suggested change
return this.page.evaluate(_ => Reveal.layout());
return this.page.evaluate(_ => Reveal.next()).then(this.page.evaluate(_ => Reveal.layout()));

WDYT?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is really needed to call it for every slide. Could you please check if calling it once in the configure method solve your issue?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check, thx for the quick feedback.

}

currentSlideIndex() {
Expand Down
Loading