track_odometry: Add enable_tcp_no_delay option to reduce latency #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatao
changed the title
[#1300] PASSED on kineticAll tests passed[#1300] PASSED on melodicAll tests passed |
|
@at-wat PTAL. |
at-wat
reviewed
Mar 31, 2020
| @@ -298,6 +298,11 @@ class TrackOdometryNode | |||
| { | |||
| neonavigation_common::compat::checkCompatMode(); | |||
|
|
|||
| bool use_tcp_no_delay; | |||
| pnh_.param("use_tcp_no_delay", use_tcp_no_delay, false); | |||
There was a problem hiding this comment.
I think the default value is OK to be true.
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 80.11% 80.17% +0.05%
==========================================
Files 64 64
Lines 4512 4514 +2
==========================================
+ Hits 3615 3619 +4
+ Misses 897 895 -2
Continue to review full report at Codecov.
|
nhatao
changed the title
[#1301] PASSED on kineticAll tests passed[#1301] PASSED on melodicAll tests passed |
[#1302] PASSED on kineticAll tests passed[#1302] FAILED on melodicTest failed[#1302] PASSED on melodicAll tests passed |
|
@at-wat PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #216
In some situations, latency of subscribers becomes large without tcpNoDelay option.
https://qiita.com/kiy_at_dev/items/1e2ae8bfa400f12e1066