safety_limiter: Add a max_linear_vel and max_angular_vel #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[47] FAILED on kineticTest failed[47] FAILED on noeticTest failed |
[47] FAILED on melodicTest failed |
[48] PASSED on melodicAll tests passed[48] PASSED on kineticAll tests passed[48] PASSED on noeticAll tests passed |
at-wat
reviewed
Feb 3, 2021
| if (en && cmd_vel_) | ||
| { | ||
| received = true; | ||
| ASSERT_NEAR(cmd_vel_->linear.x, expected_linear_velocities[linear_index], 1e-3); |
There was a problem hiding this comment.
gtest's argument order is (expected, actual)
[49] PASSED on melodicAll tests passed[49] PASSED on noeticAll tests passed[49] PASSED on kineticAll tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables to apply of maximum linear and angular values to velocity as mentioned in #580
Created also: