Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set useSession SessionDataT type to UserSession #4

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: Set useSession SessionDataT type to UserSession #4

merged 1 commit into from
Nov 9, 2023

Conversation

Gerbuuun
Copy link
Contributor

@Gerbuuun Gerbuuun commented Nov 8, 2023

Instead of asserting the session data, pass the UserSession type as a generic into the h3 useSession.
Also, use the SessionConfig instead of any.
(Although ts-ignore is used so it doesn't really do anything, it is more correct)

@atinux atinux requested a review from danielroe November 9, 2023 06:28
Copy link
Owner

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but want @danielroe expert TS eye :D

@atinux atinux changed the title Set useSession SessionDataT type to UserSession chore: Set useSession SessionDataT type to UserSession Nov 9, 2023
@danielroe danielroe merged commit b460d12 into atinux:main Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants