Feature/refactor totals

[DarkSide666]

Total support in Grid is currently quite basic, implementing ability to add up numeric values, define per-column strategies and format the footer.

This PR offers many enhancements:

Ability to add multiple Total lines

Sometimes you would want to define multiple total lines, for instance - SubTotals and Totals. They will be increased simultaneously, but will output in 2 separate lines. They will also have separate strategy.

However SubTotals need ability to be "inserted" multiple times too, which we can implement using hook beforeRow (#277).

$table->addTotals([
   'name'=>'Totals for {$category}',
   'category'=>false,  // will not output and will use colspan
   'amount'=>'sum'
], 'sub');

$last_category = null;
$table->beforeRow(function($row) use ($table) {
    if ($last_category == null) { 
      $last_category = $row['category'];
    } elseif ($last_category != $row['category']) {
      $table->renderTotals('sub', ['category'=>$last_category]);
    }
});

Advanced calculation strategies

Here for the data that contains various dates, we find and display date range in the bottom: "1 Jul - 20 Aug"

$table->addTotals([
  'date'=>[
    'default'=> [null, null],
    'row'=>function($v, $prev) {
        return [min($prev[0], $v), max($prev[1], $v]
    },
    'total'=>function($v) {
        return $v[0]->format('M d').' - '.$v[1]->format('M d');
    },
    'format' => false, // to not use date column formatter
]);

[DarkSide666]

Need to add tests for all different kinds of totals.

[romaninsh]

wow relally good PR but do I have to write all the docs myself again ? 👍

[DarkSide666]

Tomorrow I will add one more feature there. I have it now (idea) written down on paper but to sleepy to implement it now :)
Also I will write docs with examples tomorrow.

[romaninsh]

something that came to my mind was ability to specify 'name' for the total rows, e.g. addTotals('row2'), then it is safer for you to modify it. Obviously should be optional.

[DarkSide666]

Also it would be better to move all that totals functionality outside Table in separate class Totals.
That's better because:

1. make Table class simpler
2. easier to extend just Totals class and make some changes there
3. Totals class should be added to Table invisibly for user, so user still will call Table->addTotals(...) and that will do $table->totals_plan[] = new Totals(...);

[DarkSide666]

longest not shortest

[DarkSide666]

what is $t? Probably $table->nkp, right?

[DarkSide666]

inc or incr ?

[DarkSide666]

please be more specific what "empty" means here. Is 0 empty? Is empty string empty? Or is it just null. I think that 0 is not empty, but empty string is empty.

[DarkSide666]

I didn't understand this sentence.

[DarkSide666]

please add return statement here to make things clearer

[romaninsh]

looks like you over-engineer here, how about this

$t[$key] = (int)$t[$key] + $this->model[$key];

[romaninsh]

actually might be tricky because of (int) and (float)

[romaninsh]

https://stackoverflow.com/a/16606419/204819

[romaninsh]

ok, how about this:

$t[$key] = $t[$key]===null ? 0 : ($t[$key] + $this->model[$key]);

[romaninsh]

no change needed, but just note on the existence of http://php.net/manual/en/language.oop5.magic.php#language.oop5.magic.invoke

[mvorisek]

I have rebased 56da26e 1:1 and simplified the history as much as possible (by squashing CS fixer for example) into d34d398. The diff shows zero changes.

Then I have reverted the changed file paths (files) on the latest develop and rebased the changes again (now with paths matching the current develop): all original changed: c75b7ae...d34d398

[mvorisek]

Hi @DarkSide666, in my post above there is a link to view the real diff - what features/fixes are missing and can you rebase them on the latest develop?