Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T re warnings 20201214 #346

Merged
merged 7 commits into from
Jan 25, 2021
Merged

Conversation

jkeenan
Copy link
Collaborator

@jkeenan jkeenan commented Dec 14, 2020

This p.r. request cleans up all warnings in t/re/*.t with the exception of t/re/reg_mesg.t. The latter file already has a lot of tests of the text of warnings but in certain places turns warnings off. I'm corresponding with @khwilliamson about how to proceed with that file.

Otherwise, this p.r. should be reviewed so we can merge it.

For: #311

Thank you very much.
Jim Keenan

Copy link
Collaborator

@brainbuz brainbuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t/re/pat_psycho.t still has a warnings line that can be removed.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Dec 16, 2020

t/re/pat_psycho.t still has a warnings line that can be removed.

Are you sure? I'm not getting anything in that file.

[perlmonger: perl-atoomic-2] $ gitcurr
t-re-warnings-20201214
[perlmonger: perl-atoomic-2] $ ./perl -Ilib t/re/pat_psycho.t 1>out 2>err
[perlmonger: perl-atoomic-2] $ ls -l err
-rw-r--r--  1 jkeenan  jkeenan  0 Dec 16 01:22 err

@jkeenan jkeenan merged commit bf87cc4 into alpha-dev-03-warnings Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants