Mock Next.js in page router tests #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
adamjmcgrath
commented
Oct 12, 2023
| @@ -170,15 +170,6 @@ describe('with-page-auth-required ssr', () => { | |||
| delete process.env.NEXT_PUBLIC_AUTH0_LOGIN; | |||
| }); | |||
|
|
|||
| test('is a no-op when invoked as a client-side protection from the server', async () => { | |||
There was a problem hiding this comment.
We don't need this test anymore since the same withPageAuthRequired import isn't used for SSR and CSR since v3
Widcket
reviewed
Oct 12, 2023
| const parseJson = (req: IncomingMessage, res: ServerResponse): Promise<IncomingMessage> => | ||
| new Promise((resolve, reject) => { | ||
| export const parseJson = async (req: IncomingMessage, res: ServerResponse): Promise<IncomingMessage> => { | ||
| const { default: bodyParser } = await import('body-parser'); |
There was a problem hiding this comment.
Just curious, what is the reason we need a dynamic import here?
There was a problem hiding this comment.
I added a dependency on this file in tests/fixtures/server.ts which some test files that run edge tests depend on and body-parser can't be imported on the edge runtime (it must use eval or something)
Widcket
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Mock out the next test app for page router tests - since standing up a next app for every test is too expensive for the CI (didn't work in GH actions and was flakey on CircleCI)
Before:
After:
🎯 Testing
Tested on GH actions https://github.com/auth0/nextjs-auth0/actions/runs/6494889625/job/17638727581