Various CI fixes #23
Various CI fixes #23
Conversation
…r all Linux builds
|
|
.github/workflows/ci.yaml
Outdated
| @@ -56,8 +59,19 @@ jobs: | |||
| path: QuantLib-Risks-Cpp | |||
| - name: Setup | |||
| run: | | |||
| sudo apt update | |||
| sudo apt install -y libboost-dev ccache ninja-build | |||
| sudo apt-get update \ | |||
There was a problem hiding this comment.
I think we can avoid all of this if we simply use the same build container that QuantLib uses directly. Using the container argument - as it's done here with the rolling tag. That way we follow the QuantLib pre-requisites and we don't need to install all these dependencies every time.
.github/workflows/ci.yaml
Outdated
| && cd ${{ matrix.boost_dir }} \ | ||
| && ./bootstrap.sh \ | ||
| && sudo ./b2 --without-python --prefix=/usr -j 4 link=shared runtime-link=shared install \ | ||
| && cd .. && sudo rm -rf ${{ matrix.boost_dir }} && sudo ldconfig |
There was a problem hiding this comment.
and the same thing here - use the container image provided by QuantLib.
|
Can add an |
I solved the prior issue but now I'm getting a path issue. Any idea why this is happening? |
There was a problem hiding this comment.
About the path issue - the problem is the ${{ github.workspace }} doesnt resolve to the right path within the container. It point to the dir outside the container, which is not working. This is a known issue with containers - perhaps you can use something like $(pwd)/../xad etc to point to the right directory where xad is?
|
This is ready to merge. The windows cxx20 failure is not part of this pull request. |
Then please disable that workflow (comment it or put an if false). Can't merge with failing CI/CD. |
auto-differentiation-dev
merged commit 69aa4ad
into
auto-differentiation:main
Changes to merge include: