-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Aggregation Logic for 'learning_curves' Artifacts #100
base: master
Are you sure you want to change the base?
Added Aggregation Logic for 'learning_curves' Artifacts #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another high-level comment would be - once the PR #98 is merged you can sync this into your changes and try running it.
I have made some changes which fixes the confusing path names that we had before so it may change your code.
Another TODO: is to add tests for this functionality to future proof the aggregate + eval scripts
…into aggregate_learning_curves_artifacts
Added Aggregation Logic for 'learning_curves' Artifacts
Summary of Changes:
This pull request introduces enhancements to the
aggregate-amlb-results
method ofagbench
. By specifying a new config flag--artifact
, you can specify learning_curves artifacts to be collected during the aggregation script, while maintaining backwards compatibility with the previous aggregation ofresults.csv
files. Note that it is expected that you have run agbench with thelearning_curves
artifact defined in_save_artifacts
and_generate_curves
set to True.Intended Usage:
You can also aggregate across multiple artifacts at a time:
Sample Output:
Results:
The aggregation script will recursively search all objects in the benchmark and collect
learning_curves.json
files across all datasets and folds included in the experiment. Afterwards, these files will be organized by their respective datasets and fold numbers: