Support iterators and views in grpc in firewood #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still todo!() in all implementations Fixed up build.rs so that it only rebuilds the tonic things when the specs change, which is rare, speeding up incremental builds.
Made it a bit easier to add more proto files, and also report to cargo that these are the only files that cause the build.rs to run again
Still need the reader functions
danlaine
reviewed
Feb 20, 2024
These have a built-in as_str_name method we can utilize. Unfortunately, the proto system's error wants an implementation for Into<String>, so I implemented From<CommitError> for String.
rkuris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.