-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added postcss integration with autoprefixer #5
base: master
Are you sure you want to change the base?
Conversation
added new line at the eof
package.json
Outdated
"build": "webpack -p --config ./webpack.prod.js", | ||
"webpack-size": "webpack --config ./webpack.prod.js --json | webpack-bundle-size-analyzer" | ||
} | ||
"name": "showcase", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Just have one issue here. I see a lot of unnecessary diff in this file. It seems that the indentation has messed up. Please fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot replicate the issue on my machine by using an IDE or by using the github remote editor. Can you see it locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used 2-tabs in that file whereas your editor has changed it to spaces, thus that extra diff. I recommend you install an Editorconfig plugin
for your editor as it will help it respect the .editorconfig file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this has been fixed in the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the browserlist in package.json?
https://github.com/ai/browserslist#packagejson
Any reasons why keeping a separate file might be practical?
No description provided.